Skip to content

Commit

Permalink
chore: Relocated tsbuildinfo out of dist folder (#9390)
Browse files Browse the repository at this point in the history
**Problem**
The current tsconfig entry for the tsbuildinfo file puts the file into
the dist folder. This ultimately results in it being included in the
shipped packages on npm. These files are large and in some cases are the
bulk of the content in the package. For example in the
`@redwoodjs/project-config` package it makes up 75% of the package size.

From what I can read online, and my own understanding of the
functionality of that file, there is no need for this content to be
shipped with the built code on npm.

I quickly checked on my local machine and this change does not appear to
have impacted the build time.

**Change**
1. Delete the explicit entry which will place it in a default location
which is fine. The file is already ignored by the existing .gitignore.
2. Remove the code in the release tooling that removes these files. I
don't think it was fully functional right now.

**Notes**
I marked this as a chore because it doesn't influence the code just the
build step. It does change the bytes that are shipped to users so maybe
it's not a chore but I am not that concerned with the label right now.
  • Loading branch information
Josh-Walker-GM authored Nov 9, 2023
1 parent c7d70a2 commit cdfa692
Show file tree
Hide file tree
Showing 57 changed files with 1 addition and 64 deletions.
1 change: 0 additions & 1 deletion packages/api-server/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src", "ambient.d.ts"],
Expand Down
1 change: 0 additions & 1 deletion packages/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src/**/*"]
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/auth0/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/auth0/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/auth0/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/clerk/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/clerk/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/clerk/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/custom/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/dbAuth/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/dbAuth/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/dbAuth/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src", "ambient.d.ts"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/firebase/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/firebase/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/firebase/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/netlify/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/netlify/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/netlify/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/supabase/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/supabase/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/supabase/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/supertokens/api/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/supertokens/setup/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth-providers/supertokens/web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/auth/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src", "ambient.d.ts"]
Expand Down
1 change: 0 additions & 1 deletion packages/babel-config/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/cli-helpers/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/cli-packages/dataMigrate/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/cli-packages/storybook/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-plugin/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"strict": true,
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/fastify/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist"
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/forms/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"]
Expand Down
1 change: 0 additions & 1 deletion packages/graphql-server/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["ambient.d.ts", "src/**/*"],
Expand Down
1 change: 0 additions & 1 deletion packages/internal/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src/**/*", "./ambient.d.ts"],
Expand Down
1 change: 0 additions & 1 deletion packages/mailer/core/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/mailer/handlers/in-memory/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/mailer/handlers/nodemailer/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/mailer/handlers/resend/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/mailer/handlers/studio/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/mailer/renderers/mjml-react/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/mailer/renderers/react-email/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src"],
Expand Down
1 change: 0 additions & 1 deletion packages/prerender/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
"paths": {
"src/*": ["./src/*"]
Expand Down
1 change: 0 additions & 1 deletion packages/project-config/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src/**/*"],
Expand Down
1 change: 0 additions & 1 deletion packages/realtime/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
},
"include": ["src/**/*"],
Expand Down
1 change: 0 additions & 1 deletion packages/router/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "../../tsconfig.compilerOption.json",
"compilerOptions": {
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"baseUrl": ".",
"rootDir": "src",
"outDir": "dist",
Expand Down
1 change: 0 additions & 1 deletion packages/structure/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"baseUrl": ".",
"rootDir": "src",
"tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
"outDir": "dist",
"experimentalDecorators": true,
"noImplicitReturns": false,
Expand Down
Loading

0 comments on commit cdfa692

Please sign in to comment.