createStructuredSelector type definitions with auto-infer#454
Closed
toomuchdesign wants to merge 3 commits into
Closed
createStructuredSelector type definitions with auto-infer#454toomuchdesign wants to merge 3 commits into
toomuchdesign wants to merge 3 commits into
Conversation
32f4a04 to
a397a6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 15 15
=========================================
Hits 15 15 Continue to review full report at Codecov.
|
Contributor
markerikson
added a commit
to eXamadeus/reselect
that referenced
this pull request
Oct 16, 2021
Contributor
|
Closing since this is now included in #486 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Typing feature
What is the current behaviour? (You can also link to an open issue here)
Current
createStructuredSelectortype definition doesn't provide auto-inferring and need users to explicitly provide generics types.Typing definitions tested in non-strict mode
See: #428
What is the new behaviour?
Provide a different typing strategy as suggested by @oatkiller.
Updates type definitions tests to run in strict mode
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes.
createStructuredSelectorcalls to have to remove them in order to compile again with the TS compiler.Unfortunately I wasn't able to to express the new types in a non-breaking way. It may be that is possible.
Other information:
Parallelly working on a similar solution for re-reselect.
In case this gets merged in future I'd suggest the maintainers to rebuild
package-lock.jsonin commit b9ea429 on their own machines.Please check if the PR fulfills these requirements: