Expose selector's result to allow adhoc caching#448
Closed
jcready wants to merge 3 commits into
Closed
Conversation
When a selector returns a complex value it can be difficult to get caching right. This will expose a way for selectors to see their own previous result which provides a way for users to do things like return the previous result if the result of the current call will be shallowly equal to previous result.
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 15 15
=========================================
Hits 15 15
Continue to review full report at Codecov.
|
Contributor
|
Superseded by #514 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a selector returns a complex value it can be difficult to get caching right. This will expose a way for selectors to see their own previous result which provides a way for users to do things like return the previous result if the result of the current call will be shallowly equal to previous result.
See #441 for an example of the feature request. Here is how this change would facilitate the solution: