Upgrade to babel@7#381
Merged
Merged
Conversation
Andarist
commented
Oct 17, 2018
| "NODE_ENV": "commonjs" | ||
| } | ||
| }, | ||
| "compile:umd": { |
Contributor
Author
There was a problem hiding this comment.
personally I would move all builds (umd, umd:min, cjs, es) to rollup, but not sure how do u feel about it
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 2 +1
Lines 15 21 +6
=========================================
+ Hits 15 21 +6
|
Contributor
|
Seems like this still is relevant. @Andarist , any chance you could update the PR to merge cleanly? |
Contributor
Author
|
@markerikson I've rebased and confirmed that it still compiles but please re-check the current setup. |
Contributor
Author
|
Oh, I haven't spotted in a rush that this repo is not using Travis any longer 😅 |
Contributor
|
that's because I only merged the other PR like 10 minutes ago :) |
Contributor
|
Well, this seems to build cleanly. Let's get it in and move things along. Thanks, @Andarist ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.