cacheSize option for defaultMemoize#210
Closed
b6pzeusbc54tvhw5jgpyw8pwz2x6gs wants to merge 3 commits into
Closed
Conversation
Current coverage is 100% (diff: 100%)@@ master #210 diff @@
====================================
Files 1 1
Lines 12 18 +6
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 12 18 +6
Misses 0 0
Partials 0 0
|
3 similar comments
|
Thank @b6pzeusbc54tvhw5jgpyw8pwz2x6gs , this was an enlightenment. import memoizer from 'fast-memoize'
import { createSelectorCreator } from 'reselect'
// Why not Lodash's memoize?
// Because that won't work when the function takes more than one argument. And this is fast.
export const createSelector = createSelectorCreator(memoizer)
|
|
@ivawzh that's a great solution -- it would be super helpful if this were in the |
Contributor
|
Superseded by #513 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As 3rd argument, now defaultMemoize() can get the
cacheSize.There are two arrays to store previous argument arrays, previous results.
cacheSizefeature is designed as follows:In general, there is high a probability that last argument is used again.
So last arguemnts and result are added or updated to index: 0 in cacheArgsArr
andcacheResultArr`Please feel free to contact us if you have something lacking.