Can't pass props in selectors

[vasa-chi]

react-redux supports passing props to select. Currently reselect only passes state. Is it possible to add props to selector functions?

[ellbee]

I'm not sure that the new react-redux api for the connect decorator is going to support this. Check out this PR

[vasa-chi]

Huh. That would be unfortunate... Maybe @gaearon can clarify?

[vasa-chi]

Seems that there will be an additional argument for @connect decorator for using props to further filter the state. So I guess that yes, this api will get deprecated.

[ellbee]

Confirmed as gone in the release notes for react-redux v.0.5.0

[scottcorgan]

It looks like this added back in react-redux. Can we get it back in this package?

[ellbee]

Yep, I guess we should look into this now

[scottcorgan]

Any time frame on this? Attempted to jump in on a fork, but didn't know if changes were coming soon for a 1.0.

[ellbee]

Funnily enough, I was just looking at it. Did you have a plan? I'm wondering how the dumb default memoize and its reference equality is going to work with the props. I don't recall how the props are handled inside react. I guess if the prop object is mutative and has a stable reference for the lifetime of the component or it is recreated entirely on each render then we might have problems?

I think that the API might change slightly in the next version, possibly allowing the user to specify a memoization function in createSelectorCreator and allowing variadic depencies. I just started exploring this in my fork here if you'd like to have a look.

[gaearon]

I guess if the prop object is mutative and has a stable reference for the lifetime of the component or it is recreated entirely on each render then we might have problems?

Props object is new every time. It's considered immutable.