Convert class components to functional components in the API docs examples #4254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2022 09:35
mxweaver
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e822d9:
|
|
✔️ Deploy Preview for redux-docs ready! 🔨 Explore the source changes: 1e822d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/61daf7a179da9700071ef33c 😎 Browse the preview: https://deploy-preview-4254--redux-docs.netlify.app |
Contributor
|
Sweet, thank you! Yeah, there's a lot of the docs pages that need to be rewritten to show "modern Redux" and "modern React", but those have been low priority. If you'd like to try updating some of the other docs pages, that would be wonderful! |
Contributor
Author
|
My pleasure! I'll give it a whirl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 📖 New/Updated Documentation Content
about: Adding a new docs page, or updating content in an existing docs page
PR Type
Does this PR add a new page, or update an existing page?
Checklist
What docs page is being added or updated?
For Updating Existing Content
What updates should be made to the page?
The class-based react components should be converted to functional components.
Do these updates change any of the assumptions or target audience? If so, how do they change?
Converting the components to functional components assumes the audience understands the basics of functional react components and hooks. In contrast, the existing examples assume the audience understands the lifecycle methods of class components. Both of these concepts are foundational to modern React development. Still, functions and hooks seem to be the preferred method of defining a component (e.g., the React docs have mainly been rewritten to use functional components: https://reactjs.org/docs/lists-and-keys.html).