[Tutorial Docs] Updating Initial state to account for expected changes in UI #3964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for redux-docs ready! 🔨 Explore the source changes: 2aec3bd 🔍 Inspect the deploy logs: https://app.netlify.com/sites/redux-docs/deploys/5fd02fd7d0a1d600092f0ed9 😎 Browse the preview: https://deploy-preview-3964--redux-docs.netlify.app |
tylerthedeveloper
changed the title
|
Added issue - #3967 |
Shrugsy
reviewed
Mar 21, 2021
| @@ -803,6 +803,40 @@ export const ReactionButtons = ({ post }) => { | |||
|
|
|||
| Now, every time we click a reaction button, the counter should increment. If we browse around to different parts of the app, we should see the correct counter values displayed any time we look at this post, even if we click a reaction button in the `<PostsList>` and then look at the post by itself on the `<SinglePostPage>`. | |||
|
|
|||
| Whenever adding new properties to state or state objects, it is important to make sure to also update initial state if there are any defuault objects. Just like before when we added user and date to our initial state of posts, we also need to add 'initial reactions' as well. | |||
There was a problem hiding this comment.
Suggested change
| Whenever adding new properties to state or state objects, it is important to make sure to also update initial state if there are any defuault objects. Just like before when we added user and date to our initial state of posts, we also need to add 'initial reactions' as well. | |
| Whenever adding new properties to state or state objects, it is important to make sure to also update initial state if there are any default objects. Just like before when we added user and date to our initial state of posts, we also need to add 'initial reactions' as well. |
Corrects a spelling error
|
Should be resolved by #4153 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page
Checklist
What docs page needs to be fixed?
Section:
redux/docs/tutorials/essentials
Page:
part-4-using-data.md
What is the problem?
We change the UI to state that we will expect posts to have a reactions property in the ReactionButtons component, but we both don't check for null or update the initial state.
What changes does this PR make to fix the problem?
In my PR i follow the same process used earlier in the tutorial with both the user and the date property on posts, by making sure to update the initial state objects of posts to have a reactions object property.