isPlainObject better performance #3257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to go through an object entire prototypal chain. If the chain length is 1 then its prototype will be the last one in the chain.
Member
|
Thanks, you're not wrong, but we're really just bikeshedding at this point. The plain object check is quite fast as-is. If it's what's slowing you down, you probably have other problems to worry about :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to go through an object's entire prototypal chain to see if the first
protois equal to the last non-nullprotoin the chain. Just check that the object's prototypal chain has only one non-nullprotoin its chain.