docs: replace slice calls to map #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO this looks much cleaner and easier to understand, thanks very much @just-boris! I'm in a hurry right now, so I'll do a functional test soon to make sure everything still works as expected and then merge! |
|
I made changes only in Markdown files. So all code there wasn't actually executed during build. @mxstbr How are gooing to test this? |
|
Oh right, my bad, I didn't look at the code changes! Looked through it now, LGTM, thanks very much @just-boris! |
mxstbr
added a commit
that referenced
this pull request
Mar 4, 2016
docs: replace slice calls to map
| ...state.slice(action.index + 1) | ||
| ] | ||
| return state.map((todo, index) => { | ||
| if(index === action.index) { |
There was a problem hiding this comment.
Nit: we leave space after if pretty much everywhere else.
Would you mind fixing this as a separate PR?
There was a problem hiding this comment.
No problem, attached it to #1478
gaearon
added a commit
that referenced
this pull request
Mar 4, 2016
docs: fix surrounding text after changes in #1477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was discussed in #1468, ES5 array methods like
mapandfilterare recommended approach rather than array slicing.