setState + shallow rendering are now working fine #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating docs regarding React updates on Shallow Rendering: facebook/react#4019 (comment)
|
Shall we also remove jsdom from all example tests? |
|
👍 for removing jsdom. We only use it when testing components that interact with external (non-React) libraries and thus can't be fully covered with shallow rendering. Dropping jsdom removes the potential point of confusion regarding node compatiblity. If the examples lock jsdom to |
|
Opened a new issue to track removing jsdom: #1473 I think we can merge this for now and remove the notice when jsdom is removed! |
gaearon
added a commit
that referenced
this pull request
Mar 3, 2016
setState + shallow rendering are now working fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating docs regarding React updates on Shallow Rendering: facebook/react#4019 (comment)