-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding correctly typed ` prepend
and ` concat
to the array…
#559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for redux-starter-kit-docs ready! Built with commit 1395b24 https://deploy-preview-559--redux-starter-kit-docs.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1395b24:
|
Okay, moved the (Again: this is probably more readable once #549 is merged) |
Tried merging #549, but that resulted in merge conflicts for this branch somehow. Let's just go with this one instead. |
prepend
and ` concat
to the array returned by getDefaultMiddleware
. prepend
and ` concat
to the array…
Hi, maybe this isn't the best place to discuss this (sorry for that), but it's a bit awkward that the docs reflect the reference for versions that aren't published yet (I was trying to understand why the library typings didn't include the correct type definition for Btw, thank you both for your work on this library. |
@elizabeth-dev Sorry for that - I'm just finishing the docs on #610 and we'll hopefully soon release the next version. @markerikson This is actually a good point. Maybe we should deploy the docs from another branch? Might be finnicky though :/ |
Hrm. Yeah, sorry about that. We do plan to release 1.4 in the next couple days or so, so hopefully the mismatch won't last long. But yeah, for future work, let's try to do integration branches for new features + docs. |
This should solve #552 - opening as a draft PR because I want to re-review this tomorrow myself.
I streamed coding this live and it's available at https://www.youtube.com/watch?v=uQVJ6Aw3tho 😄
Also, this is based of #549, so once that is merged, this is probably more readable.