Skip to content

Adding correctly typed ` prepend and ` concat to the array… #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 13, 2020

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented May 15, 2020

This should solve #552 - opening as a draft PR because I want to re-review this tomorrow myself.

I streamed coding this live and it's available at https://www.youtube.com/watch?v=uQVJ6Aw3tho 😄

Also, this is based of #549, so once that is merged, this is probably more readable.

@netlify
Copy link

netlify bot commented May 15, 2020

Deploy preview for redux-starter-kit-docs ready!

Built with commit 1395b24

https://deploy-preview-559--redux-starter-kit-docs.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1395b24:

Sandbox Source
amazing-voice-5fqq2 Configuration
elastic-rhodes-oohp9 Configuration
weathered-shadow-3dwpn Configuration

@phryneas phryneas marked this pull request as ready for review May 23, 2020 12:00
@phryneas
Copy link
Member Author

phryneas commented May 23, 2020

Okay, moved the MiddlewareArray to utils.ts, exported it & added documentation. I believe this might be ready for review now.

(Again: this is probably more readable once #549 is merged)

@markerikson
Copy link
Collaborator

markerikson commented Jun 13, 2020

Tried merging #549, but that resulted in merge conflicts for this branch somehow. Let's just go with this one instead.

@markerikson markerikson changed the title Adding correctly typed ` prepend and ` concat to the array returned by getDefaultMiddleware . Adding correctly typed ` prepend and ` concat to the array… Jun 13, 2020
@markerikson markerikson merged commit cc8d281 into reduxjs:master Jun 13, 2020
@elizabeth-dev
Copy link

Hi, maybe this isn't the best place to discuss this (sorry for that), but it's a bit awkward that the docs reflect the reference for versions that aren't published yet (I was trying to understand why the library typings didn't include the correct type definition for middleware, when I discovered that passing a function was a recent addition. Maybe a bit of Murphy's law that I went to check specifically that part of the docs just today).

Btw, thank you both for your work on this library.

@phryneas
Copy link
Member Author

@elizabeth-dev Sorry for that - I'm just finishing the docs on #610 and we'll hopefully soon release the next version.

@markerikson This is actually a good point. Maybe we should deploy the docs from another branch? Might be finnicky though :/

@markerikson
Copy link
Collaborator

Hrm. Yeah, sorry about that.

We do plan to release 1.4 in the next couple days or so, so hopefully the mismatch won't last long.

But yeah, for future work, let's try to do integration branches for new features + docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants