-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support default return schemas in openapi codegen #4152
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d5fa42:
|
Can someone look at this? |
Bump |
@phryneas Hi, you looked at this before can you continue the review? |
@EskiMojo14 you also looked at this, can you continue the review? |
I also need this feature, it would be great if someone release it |
bump for this feature to be implemented |
Bumping again to try and get some attention... |
Thanks for giving a details explanation on how to use the temporary packages, appreciate it. |
Should be live in https://github.com/reduxjs/redux-toolkit/releases/tag/%40rtk-query%2Fcodegen-openapi%402.0.0-alpha.0 ! Please try it out and let us know if it works. |
Could we make this an opt-in or opt-out setting? This change broke my project because our code generator relies on the default responses in the OpenAPI schema to define the error responses that could be returned by an endpoint. For example: /api/v2/users:
get:
operationId: ListUsers
responses:
"200":
description: A successful response.
schema:
$ref: '#/definitions/usersList'
default:
description: An unexpected error response.
schema:
$ref: '#/definitions/errorResponse' |
@bayasdev yeah, makes sense. File a PR to make that configurable? |
@markerikson PTAL #4591 |
Accidently closed PR, reopening it here.