Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website/Docs - changed styling on active Table Of Contents link to differentiate from visited #4050

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

riqts
Copy link
Contributor

@riqts riqts commented Jan 7, 2024

This bug annoyed me while reading the docs so I decided to try fix it.

Open issue #978 - discussed and sidebar fix was implemented, so I am extending a similar implementation to TOC on each page

Not sure if there is a preferred solution to the styling here, don't mind changing it, I just picked underline and the previously existing font-weight that had incorrect css targetting.

simplescreenrecorder-2024-01-07_18.10.29.mp4

Summary:

Moved font-weight from previous unstable css targeting using infima to new working class and added an underline.
Made a copy of the Sidebar Menu's behavior that stops the flash of white when hovering over visited items (that are not active)

…debar menu behaviour (to stop the transition back to white on a visited element)
Moved font weight from previously unstable infima css targeting to recommended class. Added underline text-decorator instead of background change as the spacing in this does not match how the background colour would look in the sidebar.
Copy link

codesandbox bot commented Jan 7, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 520912b
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/659a505a1c7f4e0008c81adf
😎 Deploy Preview https://deploy-preview-4050--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Jan 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 520912b:

Sandbox Source
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@EskiMojo14
Copy link
Collaborator

image

i'm fine with the changes to active/visited but my concern is that there's not much difference between normal and hovered in dark mode - any way that could be tweaked?

@riqts
Copy link
Contributor Author

riqts commented Jan 24, 2024

@EskiMojo14

i'm fine with the changes to active/visited but my concern is that there's not much difference between normal and hovered in dark mode - any way that could be tweaked?

I am happy to do that, it does re-introduce an annoying css thing here in exchange though. docusaurus has a default a:hover color transition back to white property on these links and I just chose that color because it looks much nicer running your cursor down the list without that transition. So just lmk which you'd prefer I show both in this screen recording

simplescreenrecorder-2024-01-24_20.53.05.mp4

@markerikson markerikson merged commit 719dac5 into reduxjs:master Sep 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants