[RTK v2.0] output selector fields are currently missing in selector functions created using createDraftSafeSelector.
#3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reateDraftSafeSelector
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7306e84:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.0.0-beta.1 selectors that are created with
createDraftSafeSelector, are missing the output selector fields like:resultFunc,memoizedResultFunc,lastResult,dependencies,recomputations,resetRecomputationsandclearCache. I wasn't sure if this was by design or not, since the ts type forcreateDraftSafeSelectorCreatoris the same ascreateSelectorCreator. Therefore in TypeScript the generated draft safe selectors seem to have all the output selector fields, but will result in an error being thrown during runtime.Anyway I have a simple fix that should take care of the problem during runtime, however if you do not want the output selector fields to be attached to draft safe selectors I can also fix the ts type.