keep subscription on data while query is running #3709
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6da44eb:
|
markerikson
force-pushed
the
pr/running_subscription
branch
from
56d4644
to
f291d09
Compare
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I'm admittedly hesitant on this one because I don't like anything that involves dispatching more actions. But both of you seem to think this is a good idea, so we'll go with it. Retargeted for 2.0 and rebased. |
|
I tried doing a perf check on this, and I'm pretty concerned.
here's the "Invalidate" reload activity section for each, beta.3 on the left , PR on the right. Note that beta.3 is like 2800 ms (WHICH IS STILL REALLY BAD) and PR is 6000+ seconds (ACK):
The issue here is that every dispatching is running in a microtask and taking up another 2-5ms. I haven't counted the number of actions, but the amount of work here is going up significantly somehow. This is sort of tied into the way we're mutating the subscription data in the RTKQ middleware, and then trying to track that and generate diffs via At this point I'm inclined to kick this to "Post 2.0" (and likely to RTK 3.0) on the grounds that this needs more time to be thought through, and I'm trying to be pretty ruthless about cutting scope to get this out the door. |
- Changed `subscriptionUpdated` from a microtask to a 500ms throttle - Exposed the RTKQ internal middleware state to be returned via an internal action, so that hooks can read that state directly without needing to call `dispatch()` on every render. - Reworked tests to completely ignore `subscriptionsUpdated` in any action sequence checks due to timing changes and irrelevance - Fixed case where `invalidateTags` was still reading from store state
|
Did a bunch of work on top of this in #3824 around changing how often we sync the subscription state, and also reworked how hooks access the current subscription data. Perf seems equivalent now. |
This would fix #3706 and solve a generally long-existing problem: Prior to this PR, unsubscribed
initiatecalls without an existing cache entry don't have a return value.The downside is that now every
initiatecall creates a cache entry, even withsubscribe: false- and trigger lifecycle actions.It might make sense to target 2.0 with this.