Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax for users with noPropertyAccessFromIndexSignature enabled #3495

Conversation

evertbouw
Copy link
Contributor

closes #3494

@codesandbox
Copy link

codesandbox bot commented May 31, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 127abd5:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@EskiMojo14
Copy link
Collaborator

thanks for the report and PR! 😄

the docs CI failings seem unrelated to this change - i've opened #3496 to hopefully fix them.

i've also pulled these changes over to uncheckedindexed and published a new version 🙂

once #3496 is merged into v2.0-integration and that's pulled over to here, I'd be happy to get this merged in. (just to be safe)

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 127abd5
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/64775fad67d4cc0008288a47
😎 Deploy Preview https://deploy-preview-3495--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@EskiMojo14 EskiMojo14 merged commit 32e9081 into reduxjs:v2.0-integration May 31, 2023
@evertbouw evertbouw deleted the noPropertyAccessFromIndexSignature branch June 5, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants