Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with createDynamicMiddleware idea #3256

Closed
wants to merge 14 commits into from

Conversation

EskiMojo14
Copy link
Collaborator

see #3252 - opening PR to get a package to play with

@codesandbox
Copy link

codesandbox bot commented Mar 12, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 3b60f85
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/641dc5f7f61dde00085dcc99
😎 Deploy Preview https://deploy-preview-3256--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3b60f85:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@EskiMojo14
Copy link
Collaborator Author

having a dist/react folder seems to cause interference with RTKQ's 'react' imports - as suggested by @markerikson I've tried this on the v2.0 integration branch and this no longer occurs. As such I think this MR will need to be rebuilt to aim at that branch, so a @reduxjs/toolkit/react entry point can be added cleanly.

Technically the main part of this is not react specific, but I think a large reason to add this instead of just using existing solutions is for the ability to get a useDispatch hook that knows about injected middleware's type signature.

@EskiMojo14
Copy link
Collaborator Author

closing in favour of #3292

@EskiMojo14 EskiMojo14 closed this Mar 24, 2023
@EskiMojo14 EskiMojo14 deleted the dynamic-middleware branch March 24, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant