Update Examples to use React Router 6.8 Patterns #3134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Examples to Use React Router Dom 6.8 Patterns
Finished examples
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #2134
I have updated all of the examples that use react-router-dom to use the latest current version (6.8) along with some pattern updates that reflect React Router's docs.
In the above issue there is mention of a desire for an example that use's the new loaders pattern from react-router-dom, should I also include that example in this PR?
EDIT - Not totally certain why the build is failing in CI. Based on the logs, it might look like that bumping the examples to 6.8 caused some other inherent dependency issues?