Skip to content

Add Dispatch overload to redux module #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ValeryVS
Copy link

@ValeryVS ValeryVS commented Aug 15, 2019

Follow up from
#247

Adds Dispatch interface override to work with redux-thunk.

@ValeryVS
Copy link
Author

ValeryVS commented Aug 15, 2019

While it is works with separeted dispatch functions, like useDIspatch, it will not work with store.dispatch, because store.dispatch will try to get state and extra parameters type from thunk type, but not from state type.

But it will be ok, if you type thunk action explicitly (see test change in PR).

@ValeryVS ValeryVS force-pushed the feature/redux-dispatch-typescript-typings branch from af1901c to d46c237 Compare August 15, 2019 14:59
@artursvonda
Copy link

Anything keeping this from being merged other than conflict?

@mwibutsa
Copy link

Kindly solve the conflict in index.d.ts Before it gets merged

Copy link

@sleepwalkerfx sleepwalkerfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflicts

@timdorr timdorr closed this Feb 10, 2020
timdorr pushed a commit that referenced this pull request Feb 10, 2020
It seems #259 author is not active anymore

Closes #259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants