Allow custom keys for slider monitor #472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure doesn't have anything to do with my changes. There's some node-gyp failures, probably related to node 12 being released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly lifted from redux-devtools-dock-monitor, but there was some extra complexity around the fact that the underlying parse-key library doesn't support ctrl-[ and ctrl-]. Ideally, I would have defaulted the new props to the default bindings, but I had to settle for falling back to original logic when they are unset.
I couldn't get the example todomvc project running, but I was able to verify these changes in my own project, both with and without the new props.
Closes #471.