Skip to content

Migrate to React 19 (take 2) #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 10, 2024
Merged

Migrate to React 19 (take 2) #2216

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ad9af11
Update React and React-DOM to the new rc version
aryaemami59 May 10, 2024
0aababf
Set `@types/react` and `@types/react-dom` to temporary types packages
aryaemami59 May 10, 2024
3e6428f
Run tests against different versions of React during CI
aryaemami59 May 10, 2024
355bbfb
Remove the now deprecated `react-test-renderer` package
aryaemami59 May 10, 2024
e69306b
Replace the now removed `ReactDOM` methods
aryaemami59 May 10, 2024
48ef75f
Replace `@testing-library/react-hooks` with `@testing-library/react`
aryaemami59 May 10, 2024
7d8dd84
Update `react-is` implementation
aryaemami59 May 10, 2024
0985471
Export `IS_REACT_19` and re-use in tests
aryaemami59 May 10, 2024
8f9ec75
Update `wrapper` `props` in `useDispatch.spec.tsx` to resolve type error
aryaemami59 May 10, 2024
a3ef256
Remove unnecessary `rtl.cleanup` calls
aryaemami59 May 10, 2024
aaa1927
Add `@ts-ignore` for type issue related to `@types/react` ^18.61
aryaemami59 May 10, 2024
5df69fc
Uncomment type test
aryaemami59 May 10, 2024
0b5c116
Add TODO comment about different rendering behaviors in React 18 vs 19
aryaemami59 May 10, 2024
dc018a7
Update `react` and `@types/react` in `peerDependencies`
aryaemami59 May 10, 2024
a92e5f2
Bump `use-sync-external-store` to the new rc
aryaemami59 May 14, 2024
834f70b
Use `types-use-sync-external-store` for `@types/use-sync-external-store`
aryaemami59 May 14, 2024
2de88c0
Fix skipped tests in `ssr.spec.tsx`
aryaemami59 May 16, 2024
b9846b0
Change `.toHaveBeenCalledTimes(0)` to `.not.toHaveBeenCalled()`
aryaemami59 May 16, 2024
7d48677
Change `.toHaveBeenCalledTimes(1)` to `.toHaveBeenCalledOnce()`
aryaemami59 May 16, 2024
86779ff
Fix duplicate `React` import in `hoistStatics.ts`
aryaemami59 May 19, 2024
deda394
Bump `@testing-library/dom` to version 10.4.0
aryaemami59 Jun 26, 2024
5cb1e0a
Bump `@testing-library/jest-dom` to version 6.6.3
aryaemami59 Jun 26, 2024
ae6200b
Bump `jsdom` to version 25.0.1
aryaemami59 Jul 25, 2024
d0add7f
Bump `@testing-library/react` to version 16.1.0
aryaemami59 Sep 4, 2024
eaa8271
Fix skipped test in `test/integration/ssr.spec.tsx`
aryaemami59 Dec 6, 2024
a1fc886
Fix type of `innerMapStateToProps` in `Provider.spec.tsx`
aryaemami59 Dec 6, 2024
1cd1385
Update `hoist-non-react-statics` implementation
aryaemami59 Dec 6, 2024
e08518a
Fix `act` related issues in `test/hooks/useSelector.spec.tsx`
aryaemami59 Dec 6, 2024
c58e397
Migrate to React 19
aryaemami59 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix type of innerMapStateToProps in Provider.spec.tsx
  • Loading branch information
@aryaemami59 @markerikson
aryaemami59 authored and markerikson committed Dec 10, 2024
commit a1fc886593262cee75b96a8c35bbbf00a1aa1e6c
2 changes: 1 addition & 1 deletion test/components/Provider.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ describe('React', () => {
action.type === 'INC' ? state + 1 : state

const innerStore = createStore(reducer)
const innerMapStateToProps = vi.fn<[number], TStateProps>((state) => ({
const innerMapStateToProps = vi.fn((state: number) => ({
count: state,
}))
class Inner extends Component<TStateProps> {
Expand Down