Running react-redux with Babel 6 #212
Conversation
martincik
changed the title
| "stage": 0, | ||
| "loose": "all" | ||
| "presets": ["es2015", "stage-0", "react"], | ||
| "plugins": [ |
There was a problem hiding this comment.
Why we need to add those plugins? They should already included in presets.
There was a problem hiding this comment.
Refactored the code. Thanks. 👍
| typeof SourceClass.prototype[key] === 'function' | ||
| ).forEach(key => { | ||
| if (key !== 'render') { | ||
| if (key !== 'render' && key !== 'constructor') { |
There was a problem hiding this comment.
Is modifications in this file relative to babel6?
|
+1 |
Running react-redux with Babel 6
|
@gaearon Do we want loose mode for IE8? React-Redux previously used it but this PR does not. |
|
How is loose mode related to IE8? I thought it was about improving perf. |
|
Either way I'd prefer adding loose mode back :-). I don't know how to do it though. |
|
When not in loose mode Babel uses Object.defineProperty. You are right about the perf too though. There is a preset for loose mode. The Babel 6 PR in redux has it. |
|
Can you please fix it here? |
|
Yep, give me a minute. |
|
@ellbee Any other work there, or can I release 4.0.1 that doesn't have |
|
@gaearon Go for it. |
|
Out with 4.0.1 👍 |
Refs #206