-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(docs): remove mapDispatchToProps
invalid use case
#1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for react-redux-docs ready! Built with commit dc2c1b8 |
Tried every form of `mapDispatchToProps` `dispatch` is never missing from `props`
mapDispatchToProps
untruthy use case
mapDispatchToProps
untruthy use casemapDispatchToProps
invalid use case
Yep, that's out of date. Thanks! |
Uh.... wait, what? No, we don't pass |
See the current implementation here: react-redux/src/connect/mapDispatchToProps.js Lines 4 to 22 in ae6f033
We return the result of The existing docs were correct. Reverting. |
…)" This reverts commit ae6f033.
Hmm, my bad, it seems another HOC is injecting dispatch. |
Whoops, my bad for merging without thinking too hard! |
Tried every form of `mapDispatchToProps` `dispatch` is never missing from `props`
Tried every form of
mapDispatchToProps
dispatch
is never missing fromprops