Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that component prop 'context' really contains a React context … #1134

Merged
merged 10 commits into from
Jan 8, 2019
Merged

Ensure that component prop 'context' really contains a React context … #1134

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2c8fa0c
Ensure that component prop 'context' really contains a React context …
casdevs Dec 17, 2018
0d79a85
Update connectAdvanced.js
casdevs Dec 17, 2018
c046ae6
Update connectAdvanced.js
casdevs Dec 17, 2018
9f1edde
improved check whether context given as a prop is a real ReactContext
Dec 17, 2018
5befe04
added test for ignoring non-react-context values passed as a prop to …
Dec 17, 2018
f4262b8
Use react-is checks
timdorr Dec 17, 2018
6f72646
Just check Consumer. Good enough!
timdorr Dec 17, 2018
59ff826
improved check for context.Consumer
Jan 8, 2019
9c9e002
Merge branch 'patch-1' of https://github.com/casdevs/react-redux into…
Jan 8, 2019
50fd894
added missing export 'isContextConsumer' in rollup config
Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update connectAdvanced.js
  • Loading branch information
@casdevs
casdevs authored Dec 17, 2018
commit c046ae61cce5d45530d270bc43ce464897127985
4 changes: 3 additions & 1 deletion src/components/connectAdvanced.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ export default function connectAdvanced(
}

render() {
const ContextToUse = this.props.context && this.props.context.Consumer ? this.props.context : Context
const ContextToUse = this.props.context && this.props.context.Consumer
? this.props.context
: Context

return (
<ContextToUse.Consumer>
Expand Down