Skip to content

Consider inlining all types from Redux core #1894

Closed
@markerikson

Description

@markerikson

Right now we import several specific types from the redux core package. I actually was about to say "we have a hard dependency on the redux core", but I actually don't even see it listed as a dep, which makes me very suspicious about the v8 branch in its current form.

Anyway, we currently import these types: Action, AnyAction, Dispatch, Store, and ActionCreatorsMapObject.

We inlined our implementation of bindActionCeators a while back, but the types requirement means we still have a tie to the actual redux package.

Given our current discussion around discouraging use of redux by itself, as well as the various shenanigans with NPM, peerDeps, and redux vs @reduxjs/toolkit, I think we ought to look at inlining those types directly into the v8 codebase so that react-redux has 0 need to import anything from redux. This also goes along with the idea that any store-compatible object is legal to pass to <Provider>.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions