Use flux-standard-action dependency for test only #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Would be happy to merge this but tests are failing and we have some merge conflicts, because I've also fixed the master build. Could you please fix this PR? |
albertogasparin
force-pushed
the
move-fsa-dep
branch
from
d766ba0 to
90e679a
Compare
Contributor
Author
|
Hi @timche, branch updated and looks like it's all green now 👍 |
Member
|
Thanks, merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including FSA means adding unneeded dependencies. We keep using it inside tests so we ensure consistency. Closes #60
Note: I've removed "has no extraneous key" test because
isFSA()already does that check.