createAction should adhere to doc contract regarding errors #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you please do a rebase/merge the latest master commits in your branch to fix this PR? Would like to see Travis passing first before (maybe) merging this. |
Specifically, the documentation states the following: > If the payload is an instance of an Error object, redux-actions will automatically set action.error to true. This implies that, irrespective of the arguments provided to `createAction`, if the resulting `payload` is an Error object then the `action.error` property should be set to true. This just changes that check to ensure it is performed as stated in the docs.
Contributor
Author
|
There you go, let me know if there's anything else I can help with. |
Member
|
Looks good to me. I've merged it, thanks :) |
Contributor
Author
|
Thanks, appreciate it 👍 |
|
Any estimate on when is it going to get published? |
Member
|
I'm waiting for some other stuff to get merged, then I'll reach out to @acdlite to publish a new version. It will take another week or two, depends on how responsive the PR authors are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the documentation states the following:
This implies that, irrespective of the arguments provided to
createAction, if the resultingpayloadis an Error object then theaction.errorproperty should be set to true.This just changes that check to ensure it is performed as stated in the docs.