Rename some of the increment actions to noop. #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
|
|
||
| ```js | ||
| const increment = createAction('INCREMENT'); | ||
| const NOOP = createAction('NOOP'); |
Contributor
There was a problem hiding this comment.
Can we follow the previous casing?
Contributor
Author
There was a problem hiding this comment.
LOL I suck at programming.
Contributor
|
Thanks. This was likely copy-pasta. |
devdigital
reviewed
Jun 14, 2017
|
|
||
| ```js | ||
| let increment = createAction('INCREMENT', amount => amount); | ||
| let noop = createAction('NOOP', amount => amount); |
There was a problem hiding this comment.
Why is noop more suitable than increment for the action creator name? as the action created from this action creator is used to increment a counter?
devdigital
reviewed
Jun 14, 2017
| // As object key in handleActions: | ||
| const reducer = handleActions({ | ||
| [increment]: (state, action) => ({ | ||
| [noop]: (state, action) => ({ |
There was a problem hiding this comment.
Should this not be the action creator name (i.e. 'INCREMENT' or a const) rather than the action creator function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just starting to look at this library, but reading the README this stood out.