Skip to content

Conversation

@krisaoe
Copy link
Contributor

@krisaoe krisaoe commented Mar 5, 2017

createActions requires defaultNamespace to be exported from namespaceActions.js, added export

createActions requires defaultNamespace to be exported from namespaceActions.js, added export
@yangmillstheory
Copy link
Contributor

yangmillstheory commented Mar 5, 2017

Is this what causes #196 (comment)?

How was this ever working before?

@krisaoe
Copy link
Contributor Author

krisaoe commented Mar 5, 2017

Pretty sure.
I mentioned the issue here: verekia/js-stack-from-scratch#143
Installing @1.2.2 also fixed the warning.
This seemed like a fairly simple fix for my use case, but I haven't tested thoroughly.

@yangmillstheory
Copy link
Contributor

Can you add the export to the last line in the file? That's where all the other exports are declared. Also bump the patch version in package.json.

krisaoe and others added 4 commits March 5, 2017 21:20
@yangmillstheory
Copy link
Contributor

Thanks; I'll merge once the build finishes. Can you check 2.0.1 in your project to see if it works?

@yangmillstheory
Copy link
Contributor

By the way it was working in 2.0.0 because namespaceActions used defaultNamespace internally. It's actually a bit odd that the defaults are set in two different places.

@yangmillstheory yangmillstheory merged commit 727d9c1 into redux-utilities:master Mar 5, 2017
@krisaoe krisaoe deleted the patch-1 branch March 5, 2017 10:32
@yangmillstheory
Copy link
Contributor

Thanks again https://github.com/acdlite/redux-actions/releases/tag/v2.0.1

🍺

@krisaoe
Copy link
Contributor Author

krisaoe commented Mar 5, 2017

Great project, I'm honored 😄

@krisaoe
Copy link
Contributor Author

krisaoe commented Mar 5, 2017

I missed one of your comments.. No problems now on js-stack-from-scratch with 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants