-
Notifications
You must be signed in to change notification settings - Fork 295
Export defaultNamespace from namespaceActions.js #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
createActions requires defaultNamespace to be exported from namespaceActions.js, added export
|
Is this what causes #196 (comment)? How was this ever working before? |
|
Pretty sure. |
|
Can you add the export to the last line in the file? That's where all the other exports are declared. Also bump the patch version in |
Move defaultNamespace export to where it belongs.
Bump patch version
|
Thanks; I'll merge once the build finishes. Can you check 2.0.1 in your project to see if it works? |
|
By the way it was working in 2.0.0 because |
|
Thanks again https://github.com/acdlite/redux-actions/releases/tag/v2.0.1 🍺 |
|
Great project, I'm honored 😄 |
|
I missed one of your comments.. No problems now on js-stack-from-scratch with 2.0.1 |
createActions requires defaultNamespace to be exported from namespaceActions.js, added export