Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disable all logging #12

Closed
dalewking opened this issue Dec 11, 2018 · 1 comment
Closed

Don't disable all logging #12

dalewking opened this issue Dec 11, 2018 · 1 comment
Labels
0.2.1 bug Something isn't working

Comments

@dalewking
Copy link

dalewking commented Dec 11, 2018

I am trying to use swagger-brake as a library not from the CLI. It will actually be invoked as an integration test, because right now we have no swagger files in the code and use one generated by spring-fox at run time. That will hopefully change in the future.

But the problem is that just including swagger-brake as a library is causing some unit tests to fail. The reason is that it has a logback.xml that has:

<root level="OFF" >

which is turning off logging at the root level and I have some tests that verify that certain messages are logged.

You should only control your own logging, not all logging.

@galovics galovics added bug Something isn't working 0.3.0 labels Dec 11, 2018
galovics added a commit that referenced this issue Dec 15, 2018
…eparate gradle modules so logback.xml is not bundled with the core library
@galovics
Copy link
Member

Solved by separating the core and CLI modules into separate Gradle modules so logback.xml is not bundled anymore with the core library.

@galovics galovics added 0.2.1 and removed 0.3.0 labels Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2.1 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants