packet.hh: add assert on len() #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An assert which checks the validity of _impl before calling into it. This assert is meant to rotate previously seen undefined behavior into a node crash.
There was a problem hiding this comment.
Pull Request Overview
This PR adds defensive programming by introducing an assertion to validate the internal implementation pointer before dereferencing it in the len() method. The change aims to catch null pointer dereferences early and convert undefined behavior into controlled crashes for easier debugging.
- Added
SEASTAR_ASSERT(_impl)check in thelen()method to validate the pointer before use
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assert which checks the validity of _impl before calling into it.
This assert is meant to rotate previously seen undefined behavior into a node crash.