Skip to content

[v26.1.x] CORE-16246 schema_registry/avro: collapse primitive type objects#30641

Merged
pgellert merged 1 commit into
redpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30565-v26.1.x-465
May 29, 2026
Merged

[v26.1.x] CORE-16246 schema_registry/avro: collapse primitive type objects#30641
pgellert merged 1 commit into
redpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30565-v26.1.x-465

Conversation

@vbotbuildovich

Copy link
Copy Markdown
Collaborator

Backport of PR #30565

Avro's parsing canonical form treats a primitive object schema like
`{"type":"string"}` as equivalent to the simple string form. Redpanda
previously kept the object form, so equivalent schemas could be stored
under different canonical definitions.

Keep the existing sanitize traversal unchanged. After sanitization, walk
only the parts of the Avro JSON that are schemas: record field types,
array items, map values, and union branches. This leaves
primitive-looking custom metadata as-is.

(cherry picked from commit 2fb16bf)
@vbotbuildovich vbotbuildovich added this to the v26.1.x-next milestone May 28, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label May 28, 2026
@vbotbuildovich vbotbuildovich requested a review from pgellert May 28, 2026 22:46
@vbotbuildovich

Copy link
Copy Markdown
Collaborator Author

CI test results

test results on build#85097
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) InternalTopicProtectionLargeClusterTest test_consumer_offset_topic null integration https://buildkite.com/redpanda/redpanda/builds/85097#019e70d5-fc3a-4f99-9521-71c5d2f00a2a 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0200, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=InternalTopicProtectionLargeClusterTest&test_method=test_consumer_offset_topic

@pgellert pgellert self-assigned this May 29, 2026
@pgellert pgellert merged commit f21b013 into redpanda-data:v26.1.x May 29, 2026
20 checks passed
@tyson-redpanda tyson-redpanda modified the milestones: v26.1.x-next, v26.1.10 Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants