[v26.1.x] iceberg/transforms: return date value from day transform#30534
Merged
mmaslankaprv merged 3 commits intoJun 8, 2026
Merged
Conversation
In preparation for changing the day transform to return a date value per the Iceberg spec, allow the time transform path formatter to read the int32 unit count from either int_value or date_value. (cherry picked from commit e973698)
Per the Iceberg spec, the day transform's result type is date, not int. Align both the value produced by apply_transform and the partition-key schema derived in partition_key_type so catalogs see the spec-conformant column type. The underlying int32 (days since epoch) is unchanged, so existing on-disk data formats are unaffected. See: https://github.com/apache/iceberg/blob/e1705f4956f4b92bb6f00b593c8287bdbf61aa6c/api/src/main/java/org/apache/iceberg/transforms/Days.java#L47 (cherry picked from commit 321c9c3)
Drives records across UTC day boundaries through a partitioning_writer configured with a `day` partition spec, asserts one output file per day, and locks in that the partition key field carries a `date_value` (per the Iceberg spec) rather than an `int_value`. Adds small `day_partition_spec()` and `get_day()` helpers symmetric to the existing hourly ones. (cherry picked from commit b1dd412)
Member
|
/ci-repeat |
Collaborator
Author
CI test resultstest results on build#84992
test results on build#84997
|
Member
|
/ci-repeat 1 |
mmaslankaprv
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30515