[v25.3.x] cloud_roles: plumb metrics_tag through refresh_credentials impls#30505
Merged
WillemKauf merged 1 commit intoMay 16, 2026
Conversation
Previously when using `sts` credentials for both `tiered_storage` and `datalake` subsystems, we would accidentally register the same metric twice. Prevent this from happening by plumbing a `metrics_tag` through the `refresh_credentials` impls and use this to distinguish when registering metrics. E.g., `aws_sts` versus `aws_sts_datalake`. (cherry picked from commit 4f0f029)
Collaborator
Author
Retry command for Build#84542please wait until all jobs are finished before running the slash command |
Collaborator
Author
WillemKauf
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30489
Conflict details
implconstructor initializer list and followingif-statement formatting diverged between dev and v25.3.x. Kept v25.3.x's compactif (auto ...; cond)single-line formatting while adding the new_metrics_tag{std::move(metrics_tag)}initializer that is the actual intent of the commit.Fixes: #30504,