Skip to content

[v26.1.x] Avoid lock take snapshot#30226

Merged
bharathv merged 2 commits into
redpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30207-v26.1.x-374
Apr 18, 2026
Merged

[v26.1.x] Avoid lock take snapshot#30226
bharathv merged 2 commits into
redpanda-data:v26.1.xfrom
vbotbuildovich:backport-pr-30207-v26.1.x-374

Conversation

@vbotbuildovich

@vbotbuildovich vbotbuildovich commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

Backport of PR #30207

bharathv added 2 commits April 17, 2026 22:21
@bharathv @vbotbuildovich
tests/rm_stm: add a test for deadlock between take_snapshot and tx
f53055c 
(cherry picked from commit b906b25)
@bharathv @vbotbuildovich
rm_stm: avoid lock in take_raft_snapshot
4d6bf00 
Holding this causes lock inversion based deadlock. See the code comment
added in the coment for justification.

(cherry picked from commit 1ecafcf)
@vbotbuildovich vbotbuildovich added this to the v26.1.x-next milestone Apr 17, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 17, 2026
@vbotbuildovich vbotbuildovich requested a review from bharathv April 17, 2026 22:22
@bharathv bharathv enabled auto-merge April 17, 2026 23:49
@vbotbuildovich

vbotbuildovich commented Apr 18, 2026

Copy link
Copy Markdown
Collaborator Author

CI test results

test results on build#83357
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) ShardPlacementTest test_node_join {"disable_license": false} integration https://buildkite.com/redpanda/redpanda/builds/83357#019d9d95-2f2a-4f8b-b3fd-9c84599983ee 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShardPlacementTest&test_method=test_node_join
FLAKY(PASS) UpgradeBackToBackTest test_upgrade_with_all_workloads {"single_upgrade": false} integration https://buildkite.com/redpanda/redpanda/builds/83357#019d9d95-2f2a-4ca5-b9b7-49a9260433fc 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=UpgradeBackToBackTest&test_method=test_upgrade_with_all_workloads
FLAKY(PASS) WriteCachingFailureInjectionE2ETest test_crash_all {"use_transactions": false} integration https://buildkite.com/redpanda/redpanda/builds/83357#019d9d96-172d-4655-b1a2-bd0e003afff4 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0655, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1838, p1=0.1312, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=WriteCachingFailureInjectionE2ETest&test_method=test_crash_all

@bharathv bharathv merged commit 2533d4a into redpanda-data:v26.1.x Apr 18, 2026
20 checks passed
@tyson-redpanda tyson-redpanda modified the milestones: v26.1.x-next, v26.1.6 May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharathv bharathv bharathv approved these changes

Assignees

No one assigned

Labels

area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Milestone

v26.1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@vbotbuildovich @bharathv @tyson-redpanda