[v25.3.x] health_monitor_backend: dangling reference fix#29932
Merged
joe-redpanda merged 1 commit intoMar 23, 2026
Merged
Conversation
The inner loop within fill_aggregate_with_offline_partitions would use an iterator pointing to potentially invalid memory. Although the first few statements in the inner lambda check whether the outer iterator was stable for this duration, invalid memory was already read in iterating against the inner iterator. This change swaps 'for' for 'while', such that outer iterator stability can be checked BEFORE incrementing the inner iterator. (cherry picked from commit 092097e)
Collaborator
Author
CI test resultstest results on build#82239
|
joe-redpanda
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29909