[v24.3.x] Add compression type metric #25391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... kafka_probe. Instead of using public accessor functions for internals, make the fixture that needs this access a friend. This limits the exposure of internal to that fixture only (though of course that fixture now has more access, if it was feeling naughty) and avoids adding accessor methods to the non-test code for each thing we need to access. This is done in anticipation of a test later in this series also needing access to internals of the probe, via the fixture. (cherry picked from commit 7a7ab0f)
Move two large functions from .h to .cc. Also, remove some unused headers. (cherry picked from commit aabdddd)
Allow the produce methods of produce_consume_utils to specify a compression type. This defaults to none (the existing behavior) if not specified. (cherry picked from commit 6fe03e9)
Add a constexpr array of all the compression modes applicable to batch compression, so that we can loop over it or whatever we want. We can only hold our breath that C++35 will offer something like this built-in. Testing: Add some static asserts that the array of all compression types is as expected (count member, front and back) and that all compression types roundtrip through `fmt::format` and lexical_cast as expected. (cherry picked from commit 40239e4)
|
/dt |
Add a compression type metric which records the cumulative size of all bytes produced with a given compression type. This will help us evaluate the prevalence of compression in the wild and which types are being used. (cherry picked from commit a00f277)
travisdowns
force-pushed
the
manual-backport-25340-v24.3.x-690
branch
from
8f2330c to
0c61ac6
Compare
|
/dt |
CI test resultstest results on build#63186
test results on build#63187
|
StephanDollberg
approved these changes
Mar 15, 2025
michael-redpanda
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #25340
Fixes #25384.