[v24.3.x][CORE-9029] schema_registry/protobuf: Rewrite and fix Normalization #25128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 30f9e63)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 5813e2c)
Instead of rendering the proto, normalize the FileDescriptorProto and and use DebugString. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 6e83075)
(cherry picked from commit e8c3909)
(cherry picked from commit 0405142)
(cherry picked from commit 448e2a4)
(cherry picked from commit 740ea83)
(cherry picked from commit 192bc2c)
(cherry picked from commit fa0dd71)
(cherry picked from commit cec240f)
(cherry picked from commit 9677240)
(cherry picked from commit bb868b3)
(cherry picked from commit 21c8ad7)
(cherry picked from commit 3444e84)
…ntry Note that this is not considered to be a valid protobuf message. However some thirdparty tools do generate such proto schemas and we support it for compatibility with those. For their support, we use a patched protobuf library on our side. (cherry picked from commit 3abd347)
…peated fields (cherry picked from commit 4a6d3be)
…dering (cherry picked from commit 51c5152)
…n ordering (cherry picked from commit 664e382)
… ordering (cherry picked from commit 6785b67)
…ization ordering (cherry picked from commit 3e4e26a)
BenPope
added
area/schema-registry
IoannisRP
approved these changes
Feb 21, 2025
Format is: `DEBUG <DATE_TIME> [<SHARD>] <rest_proxy|schema_registry>_access - server.cc:<LINE_NO> - <client_ip> <user> "<METHOD> <URL> <HTTP VERSION>" <STATUS CODE> <SIZE>` E.g.: `DEBUG 2022-11-01 18:00:05,305 [shard 0] rest_proxy - server.cc:128 - 127.0.0.1 user "GET /topics HTTP/1.1" 200 2` Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 093e790) (cherry picked from commit 222e5fa)
Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 63b82c1)
IoannisRP
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #25094
Fixes #25125