raft/tests: deflake truncation_detection_test #25035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic to wait on `enqueued` stage seems incorrect and is causing the test to flake. `eneuqued` only guarantees that the request is enqueued in the raft layer and subsequent replication may still fail with not_leader error. So the sequence of flakiness is something like this. 1. wait for enqueued futures to resolve 2. force a step down 3. wait for replicated entry to be truncated. If (2) happens before the entry is appended to the leader log, the replication future fails with a not leader resulting in a test retry. Effectively (1) is not a tight enough condition to wait on to force a step down. This commit rewrites the test to replicate with a leader_ack and wait for the future to be resolved (which guarantees a lleader append) and then the replication monitor waiter should be resolved with a truncation error after leadership change. Additionally the test seems to be missing some cleanup between retries, which is fixed
CI test resultstest results on build#61589
|
|
thanks for the great cover letter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic to wait on
enqueuedstage seems incorrect and is causing the test to flake.eneuquedonly guarantees that the request is enqueued in the raft layer and subsequent replication may still fail with not_leader error. So the sequence of flakiness is something like this.If (2) happens before the entry is appended to the leader log, the replication future fails with a not leader resulting in a test retry. Effectively (1) is not a tight enough condition to wait on to force a step down.
This commit rewrites the test to replicate with a leader_ack and wait for the future to be resolved (which guarantees a lleader append) and then the replication monitor waiter should be resolved with a truncation error after leadership change.
Additionally the test seems to be missing some cleanup between retries, which is fixed
Backports Required
Release Notes