Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-8999] schema_registry/protobuf: Add test for legacy_map #25001

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Feb 2, 2025

The Confluent Schema Registry client renders maps in the expanded form demonstrated by the test, which is considered invalid by libprotobuf >= v25.

The patch required to fix this is: https://github.com/redpanda-data/vtools/pull/3434

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

Bug Fixes

  • Schema Registry/Protobuf: Fix a regression with maps.

@BenPope BenPope self-assigned this Feb 2, 2025
@BenPope BenPope added the area/schema-registry Schema Registry service within Redpanda label Feb 2, 2025
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need the patch for the bazel build too. There are some examples using single_version_override in MODULE.bazel

The Confluent Schema Registry client renders maps in the
expanded form demonstrated by the test, which is considered
invalid by libprotobuf >= v25.

The patch required to fix this is:
redpanda-data/vtools#3434

Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope force-pushed the schema_registry_protobuf_normalize_legacy_map branch from 9afe3ee to d33def4 Compare February 2, 2025 13:16
@BenPope BenPope requested a review from rockwotj February 2, 2025 13:16
@BenPope BenPope changed the title schema_registry/protobuf: Add test for legacy_map [CORE-8999] schema_registry/protobuf: Add test for legacy_map Feb 3, 2025
@BenPope BenPope marked this pull request as ready for review February 3, 2025 11:10
@BenPope BenPope enabled auto-merge February 3, 2025 12:58
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#61502
test_id test_kind job_url test_status passed
rptest.tests.datalake.compaction_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/61502#0194cbd2-3221-446f-a3c5-f203ec03e574 FLAKY 1/3
storage_single_thread_rpunit.storage_single_thread_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61502#0194cb83-58b8-4680-a0e4-3092070106b5 FLAKY 1/2

@BenPope
Copy link
Member Author

BenPope commented Feb 3, 2025

@michael-redpanda michael-redpanda merged commit 24ad88d into redpanda-data:dev Feb 3, 2025
15 of 18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-25001-v24.3.x-380 remotes/upstream/v24.3.x
git cherry-pick -x d33def4a19

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-25001-v24.2.x-865 remotes/upstream/v24.2.x
git cherry-pick -x d33def4a19

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build area/redpanda area/schema-registry Schema Registry service within Redpanda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants