rpk: add Redpanda Cloud support to rpk cluster storage mount/unmount commands
#24134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new dependency version soft-deprecates the v1alpha2 services.
Downloading using go get is not recommended per golangci-lint docs
Now we will be able to run mount/unmount commands against Redpanda Cloud clusters using the dataplane API.
r-vasquez
force-pushed
the
rpk-mount-cloud
branch
from
9129446 to
26e5aa3
Compare
|
/dt |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58088#01932da0-c15d-40a0-b28d-93765d6dfb2e |
We should default to filter `all`, otherwise we won't print any operation unless a filter is provided.
r-vasquez
force-pushed
the
rpk-mount-cloud
branch
from
72cad3a to
8650b26
Compare
r-vasquez
requested review from
twmb,
gene-redpanda and
Deflaimun
as code owners
twmb
reviewed
Nov 18, 2024
| resp, err := cl.CloudStorage.ListMountTasks(cmd.Context(), connect.NewRequest(&dataplanev1alpha2.ListMountTasksRequest{})) | ||
| out.MaybeDie(err, "unable to list mount/unmount operations: %v", err) | ||
|
|
||
| if resp != nil { |
There was a problem hiding this comment.
Is this conditional needed? MaybeDie exits on error. Can this return nil, nil?
There was a problem hiding this comment.
I am not sure, I was overly paranoid here to avoid a panic. resp is a connect wrapper of the response and I'm not sure if an empty list will produce an empty resp.
And I prefer being a little bit paranoid as we don't control the result at all. Happy to remove it if we are 100% sure this doesn't return nil, nil
twmb
approved these changes
Nov 18, 2024
4 tasks
|
/backport v24.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability for rpk to execute the following
rpk cluster storagecommands against Redpanda Cloud Clusters:Examples:
Unmount
Mount
list-mount
list-mountable
status-mount
cancel-mount
Backports Required
Release Notes