Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: fix printing new lines #23987

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

r-vasquez
Copy link
Contributor

If the message was empty, we would print new lines to stderr

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

If the message was empty, we would print new lines
to stderr
@twmb
Copy link
Contributor

twmb commented Nov 1, 2024

Merging quickly before tests -- improves stdout, and we want to catch the RC.

@twmb twmb merged commit 674aa0f into redpanda-data:dev Nov 1, 2024
16 of 20 checks passed
@twmb twmb deleted the fix-empty-line branch November 1, 2024 18:15
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/57484#0192e947-ba4d-4bd6-9fb6-8d29cf52f240:

"rptest.tests.control_character_flag_test.ControlCharacterNag.test_validate_nag_message.initial_version=.22.3.11"

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#57484

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/control_character_flag_test.py::ControlCharacterNag.test_validate_nag_message@{"initial_version":[22,3,11]}

@vbotbuildovich
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants