storage: remove assertion on is_cloud_retention_active

[ballard26]

This assertion can be triggered if a the configuration for a topic is changed between when space management sets the _cloud_gc_offset to when gc actually runs on the log. So to avoid crashing in this case the assertion is changed to an early return and a warning is logged instead.

Fixes CORE-8070

Backports Required

• none - not a bug fix
• none - this is a backport
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v24.2.x
• v24.1.x
• v23.3.x

Release Notes

• none

[dotnwat]

lgtm

[vbotbuildovich]

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/57240#0192d53e-9405-4551-aaa8-13685ac95830:

"rptest.tests.partition_force_reconfiguration_test.PartitionForceReconfigurationTest.test_basic_reconfiguration.acks=-1.restart=True.controller_snapshots=False"

[vbotbuildovich]

Retry command for Build#57240

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/partition_force_reconfiguration_test.py::PartitionForceReconfigurationTest.test_basic_reconfiguration@{"acks":-1,"controller_snapshots":false,"restart":true}

[ballard26]

/ci-repeat 4
tests/rptest/tests/partition_force_reconfiguration_test.py::PartitionForceReconfigurationTest.test_basic_reconfiguration@{"acks":-1,"controller_snapshots":false,"restart":true}

[vbotbuildovich]

the below tests from https://buildkite.com/redpanda/redpanda/builds/57345#0192db79-8dcd-43bc-9004-f2ee4667d1cf have failed and will be retried

storage_single_thread_rpunit
storage_e2e_single_thread_rpunit
gtest_raft_rpunit
partition_balancer_planner_test_rpunit

[ballard26]

The tests had previously failed either due to being flake-y or for infra issues. I've rebased this branch and am re-running the tests. Assuming all pass this should be good to merge.

[vbotbuildovich]

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/57889#01931b96-6ffa-4783-a909-2d3c7d316365

[vbotbuildovich]

/backport v24.2.x

[vbotbuildovich]

/backport v24.1.x

[vbotbuildovich]

/backport v23.3.x