Fix an oversized alloc in cluster_config schema endpoint #23773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires https://github.com/redpanda-data/vtools/pull/3213 on the cmake side |
travisdowns
reviewed
Oct 14, 2024
travisdowns
approved these changes
Oct 14, 2024
StephanDollberg
force-pushed
the
stephan/fix-cluster-config-oversized
branch
from
91d18d2
to
c231284
Compare
This uses zero copy encoding into the output stream avoiding oversized allocations. Ref CORE-7802
StephanDollberg
force-pushed
the
stephan/fix-cluster-config-oversized
branch
from
c231284
to
7b4cfb0
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56902#0192ae7d-63f1-4b36-ae36-00b8ad5854c5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some fixes to the seastar json encoder we can now use
ss::json::stream_objectavoiding oversized allocs that get triggered by usingplain
ss::json::json_return_type.Backports Required
Release Notes