Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] rpk: introduce license warnings messages #23702

Merged
merged 6 commits into from
Oct 18, 2024
Merged

[v24.2.x] rpk: introduce license warnings messages #23702

merged 6 commits into from
Oct 18, 2024

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Oct 9, 2024 •
edited
Loading

Manual backport of the license warning features, PRs #23472 and #23744

Had to be done manually as in v24.2.x we don't have the BUILD files.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@r-vasquez
rpk: introduce license warnings messages
c8b4b07 
This commit introduces a license warning message
whenever rpk creates an admin client and the
cluster has enterprise features with an invalid
license.

(cherry picked from commit 1f1e0cd)
@r-vasquez
rpk: redact password when printing the profile
12a5fe8 
Fixes redpanda-data#13427

(cherry picked from commit 477ccb8)
@r-vasquez
rpk: rename version expected sha
b579462 
The initial intent was to keep older version's SHAs
but we are replacing the SHA when we change the
rpk version.

(cherry picked from commit 9b69ce7)
@daisukebe daisukebe mentioned this pull request Oct 10, 2024
Closed
7 tasks
@r-vasquez
rpk: change license nag cache and message
a10bc52 
(cherry picked from commit 3c30a00)
@r-vasquez
rpk: add feature violations to license info
c96c1b5 
(cherry picked from commit df9943e)
@r-vasquez
rpk: check for empty profiles in license check.
d99160f 
This is to avoid a panic in the edge case when the
user has a nameless profile (corrupted file)

(cherry picked from commit 44dfa80)
@r-vasquez r-vasquez marked this pull request as ready for review October 17, 2024 16:50
@vbotbuildovich
Copy link
Collaborator

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56754#01929bad-7c61-498d-b586-83291b3258ae:

"rptest.transactions.tx_atomic_produce_consume_test.TxAtomicProduceConsumeTest.test_basic_tx_consumer_transform_produce.with_failures=True"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 17, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56754#01929bad-7c61-498d-b586-83291b3258ae
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56754#01929ba6-aa78-4cc9-b9a4-67303155b86c
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56754#01929c2a-db43-43d9-b2e9-f5fe4198800b

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#56754

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/transactions/tx_atomic_produce_consume_test.py::TxAtomicProduceConsumeTest.test_basic_tx_consumer_transform_produce@{"with_failures":true}

gene-redpanda
gene-redpanda approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r-vasquez r-vasquez merged commit 8a4b1b4 into redpanda-data:v24.2.x Oct 18, 2024
25 checks passed
@BenPope BenPope added this to the v24.2.8 milestone Oct 21, 2024
@r-vasquez r-vasquez deleted the backport-pr-23472-v24.2.x-manual branch October 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

@mattschumpert mattschumpert Awaiting requested review from mattschumpert

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
v24.2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@r-vasquez @vbotbuildovich @gene-redpanda @BenPope