[v24.2.x] rpk: brokers list exposing Host/Port/Rack/UUID #23686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose each broker's host, port, rack, and UUID in the 'rpk redpanda admin brokers list' command. Also add a new flag '--include-decommissioned' to list decommissioned brokers with their UUIDs. (cherry picked from commit 08e30aa)
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/56051#01926e77-3812-40fc-b817-f86d709a3539 have failed and will be retried |
daisukebe
reviewed
Oct 9, 2024
| @@ -37,7 +37,7 @@ require ( | |||
| github.com/pkg/errors v0.9.1 | |||
| github.com/prometheus/client_model v0.6.1 | |||
| github.com/prometheus/common v0.59.1 | |||
| github.com/redpanda-data/common-go/rpadmin v0.1.6 | |||
| github.com/redpanda-data/common-go/rpadmin v0.1.7 | |||
There was a problem hiding this comment.
v24.2.x still uses v0.1.6, https://github.com/redpanda-data/redpanda/blob/v24.2.x/src/go/rpk/go.mod#L40, but it should be v0.1.7 to use the new GetBrokerUuids endpoint. Wonder why build didn't fail.
There was a problem hiding this comment.
It should be fine as your PR also bumped the rpadmin version to v0.1.7
r-vasquez
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23595