dt/debug-bundle: Fixed tests #23586
Merged
dt/debug-bundle: Fixed tests #23586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to some merge ordering schenangians, these tests started failing when redpanda-data#23557 merged after redpanda-data#23508. This change addresses the test bug by properly obtaining the configuration property and handling a situation when the debug bundle directory configuration is empty. Signed-off-by: Michael Boquard <michael@redpanda.com>
oleiman
approved these changes
Oct 2, 2024
| try: | ||
| data_dir = admin.get_cluster_config(node=node, | ||
| key="debug_bundle_storage_dir") | ||
| data_dir = admin.get_cluster_config( |
There was a problem hiding this comment.
seems like Admin.get_cluster_config could be massaged a bit to avoid this exception handling noise, but so be it.
There was a problem hiding this comment.
yeah fair, I have a follow up coming shortly and will address in there, just wanted to get things 'green' again asap
|
Thanks, I thought I'd tested it on top of the metadata PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to some merge ordering schenangians, these tests started failing when #23557 merged after #23508. This change addresses the test bug by properly obtaining the configuration property and handling a situation when the debug bundle directory configuration is empty.
Backports Required
Release Notes