Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: updates iceberg property description #23576

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Deflaimun
Copy link
Contributor

@Deflaimun Deflaimun commented Sep 30, 2024

Updates iceberg_enable cluster property with documentation suggestions.
Introduced on #23443

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

"is set to false, disables the feature at the cluster level effectively "
"turning it off for all topics.",
"When set to true, this enables the feature that translates topic data "
"to Iceberg tables. This enables it at the cluster level, and it "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables it at the cluster level

This gives an impression that the cluster level default is set to true, should we reword it to say that this only enables the feature and the default for all topics is still false?

Copy link

@micheleRP micheleRP Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bharathv. How is this:

Enables the feature that translates topic data to Iceberg tables. When set to true, this enables the feature at the cluster level and requires individual topics to explicitly opt in by setting the iceberg.enabled topic-level property to true. When set to false, this disables the feature at the cluster level, effectively turning it off for all topics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Deflaimun Deflaimun force-pushed the update-description-datalake-property branch from 930eab9 to 96059c9 Compare October 1, 2024 14:09
@Deflaimun
Copy link
Contributor Author

Updated the PR with the latest suggestion.

Copy link

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Paulo!

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/55543#019248c0-de55-4e7b-8166-7b9ec251d28d:

"rptest.tests.read_replica_e2e_test.TestReadReplicaService.test_writes_forbidden.partition_count=10.cloud_storage_type=CloudStorageType.ABS"

@mmaslankaprv mmaslankaprv merged commit 7ce85d7 into dev Oct 2, 2024
14 of 17 checks passed
@mmaslankaprv mmaslankaprv deleted the update-description-datalake-property branch October 2, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants