Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: various space management non-functional changes #18314

Merged
Prev Previous commit
Next Next commit
resource_mgmt: tweak info log in space management
I found the existing logging a bit confusing because "tiered storage
retention" isn't widely used verbiage. This tweaks it to refer to this
as "space management of tiered storage topics".

Also s/recover/remove: it feels a bit clearer, segment removal isn't
referred to as "recovering" in other contexts.
  • Loading branch information
andrwng committed May 8, 2024
commit c8eb9e7c734c1b3f5ced14feacd8d8a122ca25d3
8 changes: 5 additions & 3 deletions src/v/resource_mgmt/storage.cc
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,9 @@ ss::future<> disk_space_manager::manage_data_disk(uint64_t target_size) {
vlog(
rlog.info,
"Log storage usage {} > target size {} by {} (adjusted {}). Garbage "
"collection expected to recover {}. Overriding tiered storage "
"retention to recover {}. Total estimated available to recover {}",
"collection expected to remove {}. Space management of tiered "
"storage topics to remove {}. Total estimated available to remove "
"{}",
human::bytes(usage.usage.total()),
human::bytes(target_size),
human::bytes(real_target_excess),
Expand Down Expand Up @@ -641,7 +642,8 @@ ss::future<> disk_space_manager::manage_data_disk(uint64_t target_size) {
vlog(
rlog.info,
"Log storage usage {} > target size {} by {} (adjusted {}). Garbage "
"collection expected to recover {}.",
"collection expected to remove {}. No additional space management "
"required",
human::bytes(usage.usage.total()),
human::bytes(target_size),
human::bytes(real_target_excess),
Expand Down